merge integration part 2 #1915
Merged
merge integration part 2 #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix doc comments that had a incorrect line break * Remove unneeded explicit lifetimes from many impls that can elide them * Pin Rust toolchain version in workflow to avoid unexpected breaks like this going forward
…xp histograms (filodb#1891) * Use min and max when available to calculate better quantiles and fractions. * Fix perf benchmarks with updated results * Calculate rate correctly along with min and max when doing sum(rate(histogram))
Co-authored-by: Kier Petrov <[email protected]>
…ns with offsets (filodb#1910) Co-authored-by: Brian-Yu <[email protected]>
|
retest this please |
vishramachandran
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
New behavior :
BREAKING CHANGES
If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.
Breaking changes may include:
Other information: